Skip to content

fix(auth): replace exec() with execFile/spawn to prevent shell injection (#79) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
draix wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Open

fix(auth): replace exec() with execFile/spawn to prevent shell injection (#79) #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/auth/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,13 +44,21 @@ export async function startBrowserFlow(

const authUrl = `${config.authorizationUrl}?${params}`;

// Open browser
const { exec } = await import('child_process');
// Open browser using execFile/spawn instead of exec to prevent shell injection.
// exec() passes the string to a shell, so a crafted authUrl containing shell
// metacharacters (e.g. from a malicious authorization server redirect) could
// execute arbitrary commands. execFile/spawn bypass the shell entirely. (#79)
const { execFile, spawn } = await import('child_process');
const platform = process.platform;
const openCmd = platform === 'darwin' ? 'open' :
platform === 'win32' ? 'start' : 'xdg-open';

exec(`${openCmd} "${authUrl}"`);
if (platform === 'darwin') {
execFile('open', [authUrl]);
} else if (platform === 'win32') {
// On Windows, 'start' is a shell built-in — use cmd.exe /c start explicitly.
spawn('cmd.exe', ['/c', 'start', '', authUrl], { shell: false, detached: true });
} else {
execFile('xdg-open', [authUrl]);
}
process.stderr.write('Opening browser to authenticate with MiniMax...\n');

// Start local server to receive callback
Expand Down