Add an Option to Outline to the Local Player Model#340
Open
NicBelanger23 wants to merge 5 commits into
Open
Conversation
Member
|
Sorry for the long delay responding to this PR. For context, we've been busy doing major internal refactors including changing the i18n translation file format, refactoring the config system into a separate model and interface, and porting from multiple MC-version branches to a single multi-version branch (using stonecutter). The feature itself sounds useful and the approach used seems simple enough to maintain. Are you willing to rebase your PR on the latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love this mod and figured I'd try to address a small gripe I have with it.
I often find that when flying around I can lose where my player is, and need to exit freecam to regain my bearings.
This is my first experience with Fabric API and modding Minecraft in general, so please point out anything outside of best practice. Thanks!