Fix getAssetsIndex task for FG1.0#1075
Conversation
954e0eb to
57c9ee0
Compare
| public static final OperatingSystem OPERATING_SYSTEM = getOs(); | ||
| public static final SystemArch SYSTEM_ARCH = getArch(); | ||
| public static final String HASH_FUNC = "MD5"; | ||
| public static final String USER_AGENT = "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11"; |
There was a problem hiding this comment.
Do not run code formatters over existing code.
It makes your entire change set a pain to actually read/understand
There was a problem hiding this comment.
I formatted it on a whim, do I need to undo it?
| public static final String FERNFLOWER = "{CACHE_DIR}/minecraft/fernflower.jar"; | ||
| public static final String EXCEPTOR = "{CACHE_DIR}/minecraft/exceptor.jar"; | ||
| public static final String ASSETS = "{CACHE_DIR}/minecraft/assets"; | ||
| public static final String JSONS_DIR = "{CACHE_DIR}/minecraft/versionJsons"; |
There was a problem hiding this comment.
Don't use upper cases in directory names
|
Ya, gave this another pass, can you provide an example buildscript that you've used to test this? |
This is a development package I packaged locally, similar to MDK 1.7.10. This is the build script it uses. It uses Gradle 4. The version numbers might be inconsistent because the Gradle version wasn't upgraded in the PR. I remember seeing this PR with version 1.0.1 |
The script has been provided; I recall that setupWorkspace and build are both available. |
@LexManos Please review it