Skip to content

Fix getAssetsIndex task for FG1.0#1075

Open
zeng-github01 wants to merge 2 commits into
MinecraftForge:FG_1.0from
zeng-github01:FG_1.0-assets-download
Open

Fix getAssetsIndex task for FG1.0#1075
zeng-github01 wants to merge 2 commits into
MinecraftForge:FG_1.0from
zeng-github01:FG_1.0-assets-download

Conversation

@zeng-github01
Copy link
Copy Markdown

@zeng-github01 zeng-github01 commented May 18, 2026

@LexManos Please review it

@zeng-github01 zeng-github01 force-pushed the FG_1.0-assets-download branch from 954e0eb to 57c9ee0 Compare May 18, 2026 12:31
public static final OperatingSystem OPERATING_SYSTEM = getOs();
public static final SystemArch SYSTEM_ARCH = getArch();
public static final String HASH_FUNC = "MD5";
public static final String USER_AGENT = "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.11 (KHTML, like Gecko) Chrome/23.0.1271.95 Safari/537.11";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not run code formatters over existing code.
It makes your entire change set a pain to actually read/understand

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I formatted it on a whim, do I need to undo it?

public static final String FERNFLOWER = "{CACHE_DIR}/minecraft/fernflower.jar";
public static final String EXCEPTOR = "{CACHE_DIR}/minecraft/exceptor.jar";
public static final String ASSETS = "{CACHE_DIR}/minecraft/assets";
public static final String JSONS_DIR = "{CACHE_DIR}/minecraft/versionJsons";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use upper cases in directory names

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@LexManos
Copy link
Copy Markdown
Member

Ya, gave this another pass, can you provide an example buildscript that you've used to test this?
I can't get this to function so im trying to see what you're seeing.

@zeng-github01
Copy link
Copy Markdown
Author

zeng-github01 commented May 23, 2026

Ya, gave this another pass, can you provide an example buildscript that you've used to test this?
I can't get this to function so im trying to see what you're seeing.

buildscript {
    repositories {
        mavenCentral()
        maven { url uri('local-maven') }
        maven {
            name = "forge"
            url = "https://files.minecraftforge.net/maven"
        }
    }
    dependencies {
        classpath 'net.minecraftforge.gradle:ForgeGradle:1.0.3'
    }
}

apply plugin: 'forge'

sourceCompatibility = '1.7'
targetCompatibility = '1.7'

version = "1.0"
group = "org.Example"
archivesBaseName = "Example"

minecraft {
    version = "1.6.4-9.11.1.964"
    //Apply AccessTransformer here uncomment below
//    accessTransformer("")
}

repositories {
    maven { url "https://cursemaven.com" }
}

dependencies {
}

processResources {
    duplicatesStrategy = DuplicatesStrategy.INCLUDE

    inputs.property "version", project.version

    from(sourceSets.main.resources.srcDirs) {
        include 'mcmod.info'
        expand 'version': project.version
    }
    from(sourceSets.main.resources.srcDirs) {
        exclude 'mcmod.info'
    }
}

jar {
    manifest {
        attributes(
                "FMLCorePlugin": "com.example.MinecraftModifier",
                "FMLCorePluginContainsFMLMod": "true"
        )
    }
}

task deobfJar(type: Jar) {
    from sourceSets.main.output

    classifier = 'dev'
}



artifacts {
    archives deobfJar
}

This is a development package I packaged locally, similar to MDK 1.7.10. This is the build script it uses. It uses Gradle 4.

The version numbers might be inconsistent because the Gradle version wasn't upgraded in the PR. I remember seeing this PR with version 1.0.1

@zeng-github01
Copy link
Copy Markdown
Author

Ya, gave this another pass, can you provide an example buildscript that you've used to test this?
I can't get this to function so im trying to see what you're seeing.

The script has been provided; I recall that setupWorkspace and build are both available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants