Fix screen capture cropping issue#27
Closed
subbon wants to merge 1 commit intoMineDojo:mainfrom
Closed
Conversation
On my setup (Windows 11, RTX 4070 Ti Super), I encountered an issue where the game capture was significantly cropped (zoomed into the top-left corner). It appears that the bounding box coordinates passed to dxcam were calculated as (left, top, width, height), which resulted in an incorrect capture region on my machine. I modified game_env.py to pass (left, top, right, bottom) instead, which fixed the cropping issue for me. Additionally, I added SetProcessDpiAwareness to ensure correct coordinate handling on High DPI displays, although the coordinate fix was the primary solution in my case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On my setup (Windows 11, RTX 4070 Ti Super), I encountered an issue where the game capture was significantly cropped (zoomed into the top-left corner).
It appears that the bounding box coordinates passed to dxcam were calculated as (left, top, width, height), which resulted in an incorrect capture region on my machine.
I modified game_env.py to pass (left, top, right, bottom) instead, which fixed the cropping issue for me.
Additionally, I added SetProcessDpiAwareness to ensure correct coordinate handling on High DPI displays, although the coordinate fix was the primary solution in my case.