fix: add mc binary to PATH in e2e CI job#58
Merged
Conversation
The e2e job builds `mc` to `$GITHUB_WORKSPACE/bin/mc` but never adds that directory to `$PATH`. When the orchestrator server shells out to `mc task create` during POST /api/tasks, exec.Command cannot find the binary, causing a 500 error. Uses `$GITHUB_PATH` to make the binary available for the full job. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcto$GITHUB_WORKSPACE/bin/mcbut never adds that directory to$PATHmc task createduringPOST /api/tasks,exec.Commandcan't find the binary, returning a 500$GITHUB_PATHstep somcis available for the entire e2e jobRoot cause
handleCreateTaskinorchestrator/api/handlers.gocallss.runMC("task", "create", ...)which usesexec.Command("mc", ...). The binary exists at$GITHUB_WORKSPACE/bin/mcbut that's not on$PATH.Test plan
POST /api/tasksshould return 201 instead of 500🤖 Generated with Claude Code