Skip to content

Se agregan los campos createdAt, updatedAt, requeridos por la API RES…#20

Open
fdanielpm wants to merge 1 commit into
Mifiel:masterfrom
fdanielpm:master
Open

Se agregan los campos createdAt, updatedAt, requeridos por la API RES…#20
fdanielpm wants to merge 1 commit into
Mifiel:masterfrom
fdanielpm:master

Conversation

@fdanielpm
Copy link
Copy Markdown

@fdanielpm fdanielpm commented May 28, 2026

Se agregan los campos createdAt, updatedAt, requeridos por la API REST/JSON al objeto com.mifiel.api.objects.Viewer, sin éstos campos se genera un error, al crear un documento o listarlo, cuando se han agregado espectadores a la firma del documento.

Summary by CodeRabbit

  • New Features
    • Viewer objects now include timestamp fields for creation and update dates, allowing you to see when records were created and last modified.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

The Viewer class now includes createdAt and updatedAt timestamp fields with JSON property mappings to created_at and updated_at, along with public getter and setter methods for both fields.

Changes

Viewer Timestamp Properties

Layer / File(s) Summary
Timestamp fields and accessors
src/main/java/com/mifiel/api/objects/Viewer.java
Adds private createdAt and updatedAt String fields with @JsonProperty annotations, plus four accessor methods (getters and setters for both timestamp fields).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit of time keeps the dates aligned,
Timestamps now flow through Viewer designed,
Created and updated, fields so neat,
With getters and setters, the pattern's complete! ⏰

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding createdAt and updatedAt fields to the Viewer object as required by the REST API.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/main/java/com/mifiel/api/objects/Viewer.java (1)

77-91: ⚡ Quick win

Inconsistent indentation detected.

The new getter and setter methods use tab characters for indentation, while the rest of the file uses spaces (4 spaces per indent level). Please update the indentation to maintain consistency with the existing code style.

📐 Suggested fix for indentation consistency

Replace tabs with 4 spaces in the new methods:

-	public String getCreatedAt() {
-		return createdAt;
-	}
+    public String getCreatedAt() {
+        return createdAt;
+    }

-	public void setCreatedAt(String createdAt) {
-		this.createdAt = createdAt;
-	}
+    public void setCreatedAt(String createdAt) {
+        this.createdAt = createdAt;
+    }

-	public String getUpdatedAt() {
-		return updatedAt;
-	}
+    public String getUpdatedAt() {
+        return updatedAt;
+    }

-	public void setUpdatedAt(String updatedAt) {
-		this.updatedAt = updatedAt;
-	}
+    public void setUpdatedAt(String updatedAt) {
+        this.updatedAt = updatedAt;
+    }
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/main/java/com/mifiel/api/objects/Viewer.java` around lines 77 - 91, The
new getter/setter methods in class Viewer (getCreatedAt, setCreatedAt,
getUpdatedAt, setUpdatedAt) use tab characters for indentation; replace those
tabs with four space characters per indent level so they match the file's
existing 4-space indentation style and maintain consistency across the class.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/main/java/com/mifiel/api/objects/Viewer.java`:
- Around line 77-91: The new getter/setter methods in class Viewer
(getCreatedAt, setCreatedAt, getUpdatedAt, setUpdatedAt) use tab characters for
indentation; replace those tabs with four space characters per indent level so
they match the file's existing 4-space indentation style and maintain
consistency across the class.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55b0119a-6a24-4905-ad0a-6a0e7f5b65b6

📥 Commits

Reviewing files that changed from the base of the PR and between c3c018b and 338b1c1.

📒 Files selected for processing (1)
  • src/main/java/com/mifiel/api/objects/Viewer.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant