Updated lib/util.js for avoiding TypeError: Not a string or buffer#2
Open
statefull wants to merge 1 commit intoMidnightLightning:masterfrom
Open
Updated lib/util.js for avoiding TypeError: Not a string or buffer#2statefull wants to merge 1 commit intoMidnightLightning:masterfrom
statefull wants to merge 1 commit intoMidnightLightning:masterfrom
Conversation
In addressToPubKeyHash decoding a base58 address (bitcoin address) returns a byte array but twoSha256, concretely, sha256 requires a string or a buffer, so, to avoid errors performing sha256, the returned byte array is converted to a buffer.
Owner
|
It appears that function isn't really used in the application at all (I can't find a reference to |
Author
|
Hi, Yes, it is used in exit API at mods/exit/pubkeys.js line 254 // Convert Bitcoin address to pubkey hash |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid error TypeError: Not a string or buffer when calling api request pubkeys/register?keys=
Explanation:
In addressToPubKeyHash decoding a base58 address (bitcoin address) returns a byte array but twoSha256, concretely, sha256 requires a string or a buffer, so, to avoid errors performing sha256, the returned byte array is converted to a buffer.