Osa enhancements#378
Open
BenReed161 wants to merge 2 commits into
Open
Conversation
allowed 1 hex char (max 0xf) but needs 2 for the 5-bit Gen6 mask (0x1f) allowed 2 hex chars (max 0xff) but needs 3 for the 9-bit mask (0x1ff)
Fix alignment issue, previously Gen5 ended with newline so Gen6 was forced to new line, removed so all gens remain on one line. Pattern section was using the os_type link rate instead of the pattern link rate. Fixed logical AND which should be bitwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.