Skip to content

defect #3035385: Icons are not adapting to dark theme #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SerbanIonescu wants to merge 2 commits into
base: master
Choose a base branch
from
Open

defect #3035385: Icons are not adapting to dark theme #150

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e84fba
defect #3035385: Icons are not adapting to dark theme
SerbanIonescu Feb 24, 2026
2d2f97e
Extracted magic number to a constant
SerbanIonescu Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions ...-eclipse-plugin/src/com/hpe/octane/ideplugins/eclipse/ui/util/icon/EntityIconFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import org.eclipse.swt.graphics.GC;
import org.eclipse.swt.graphics.Image;
import org.eclipse.swt.graphics.ImageData;
import org.eclipse.swt.graphics.PaletteData;
import org.eclipse.swt.graphics.Point;
import org.eclipse.swt.widgets.Display;

Expand All @@ -58,6 +59,7 @@ public class EntityIconFactory {

private Color fontColor = new Color(Display.getCurrent(), 255, 255, 255);
private static Image activeImg = ImageResources.ACTIVEITEM.getImage();
private static final int imageDataDepth = 32;

private static EntityIconFactory instance;

Expand Down Expand Up @@ -105,24 +107,36 @@ public static EntityIconFactory getInstance() {
return instance;
}

private ImageData loadImageData(Entity entity, int iconSize, int fontSize) {
private ImageData loadImageData(Entity entity, int iconSize, int fontSize) {

Color color = entityColorMap.get(entity);
Color color = entityColorMap.get(entity);
String initials = entityLabelService.getEntityInitials(entity);

Display display = Display.getDefault();
Image img = new Image(display, iconSize, iconSize);

PaletteData palette = new PaletteData(0xFF0000, 0x00FF00, 0x0000FF);
ImageData data = new ImageData(iconSize, iconSize, imageDataDepth, palette);
data.alphaData = new byte[iconSize * iconSize];

Image img = new Image(display, data);

setUpGraphics(img, display, initials, color, iconSize, fontSize);

ImageData imgData = img.getImageData();
img.dispose();
return imgData;
}

private void setUpGraphics(Image image, Display display, String initials, Color color, int iconSize, int fontSize) {
GC gc = new GC(image);
gc.setBackground(display.getSystemColor(SWT.COLOR_WHITE));
gc.fillRectangle(0, 0, iconSize, iconSize); // fill the whole image with white
GC gc = new GC(image);

gc.setAntialias(SWT.ON);

gc.setAdvanced(true);
gc.setAlpha(0);
gc.fillRectangle(0, 0, iconSize, iconSize);

gc.setAlpha(255);
gc.setBackground(color);
gc.fillOval(0, 0, iconSize, iconSize); // fill an oval in the middle of the picture with the background color

Expand Down