Add XLEN parameter. #5
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBell
reviewed
Jan 9, 2025
| ); | ||
|
|
||
| reg [31:0] registers [1:NUM_REGS-1]; | ||
| reg [XLEN-1:0] registers [1:NUM_REGS-1]; |
Owner
There was a problem hiding this comment.
There's some 31s further down that will need fixing.
MichaelBell
reviewed
Jan 9, 2025
cpu/core.v
Outdated
| reg [3:0] data_rd; | ||
| reg wr_en; | ||
|
|
||
| reg [31:0] tmp_data; |
Owner
|
This is certainly interesting, but I don't think I would tape out a 64-bit version myself. However, if you're interested in doing that (or using an RV64E TinyQV for another purpose!) I would be happy to accept the change so we can stay on a common code base, providing we can find a fix for the test duplication. |
ahmedcharles
force-pushed
the
xlen
branch
2 times, most recently
from
180dd6d to
7751b9d
Compare
Contributor
Author
|
I tried changing decode to add 64bit specific opcodes and the way generate works in verilog make that fairly annoying, so I'm not sure what the best approach would be here. I wouldn't want to make the code harder to read/maintain just for the curiosity of trying out RV74. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like a better solution to testing than copying the entire thing but I'm not sure how to get cocotb to specify the parameters in the tb, though some searching suggests that there is a way, I didn't find what that way was.