Skip to content

Allow all particles in ParticleListSettings#6407

Merged
Big-Iron-Cheems merged 2 commits into
MeteorDevelopment:masterfrom
machiecodes:particlelistsetting-fix
May 16, 2026
Merged

Allow all particles in ParticleListSettings#6407
Big-Iron-Cheems merged 2 commits into
MeteorDevelopment:masterfrom
machiecodes:particlelistsetting-fix

Conversation

@machiecodes
Copy link
Copy Markdown
Contributor

@machiecodes machiecodes commented May 16, 2026

Type of change

  • Bug fix
  • New feature

Description

Removed the instanceof ParticleOptions check when creating particle list settings. Originally only particles of type SimpleParticleType would be shown, because they implement both ParticleType and ParticleOptions, however several other particles like potion swirls use a separate ParticleOptions which would cause them to be dropped

Related, because block destroy particles were previously excluded by the filter, the dedicated setting has been removed to prefer using the particles setting. It also seems like the Flash particle type was hardcoded to always render during the 26.1.2 port but I was unable to find anywhere that depended on the particle being created, so I removed the block and it can be canceled properly

Related issues

N/A

How Has This Been Tested?

Compiled a list of every particle that was previously blocked, which includes:

  • Entity Effect / Effect / Instant Effect
  • Dust
  • Dust Color Transition
  • Dragon Breath
  • Tinted Leaves
  • Block / Block Marker / Block Crumble
  • Falling Dust
  • Dust Pillar
  • Sculk Charge
  • Vibration
  • Shriek
  • Trail
  • Flash

And created commands blocks to spawn each, NoRender now keeps them from spawning:

8mb.video-5E1-rIzWERnC.mp4

Also played in normal anarchy server for ~1 hour and experienced no new bugs or weirdness

Checklist:

  • My code follows the style guidelines of this project.
  • I have added comments to my code in more complex areas.
  • I have tested the code in both development and production environments.

@Big-Iron-Cheems Big-Iron-Cheems merged commit 65dcf4b into MeteorDevelopment:master May 16, 2026
1 check passed
@machiecodes machiecodes deleted the particlelistsetting-fix branch May 16, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants