Allow all particles in ParticleListSettings#6407
Merged
Big-Iron-Cheems merged 2 commits intoMay 16, 2026
Merged
Conversation
Unclear why this was special cased?
crosby-moe
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Removed the
instanceof ParticleOptionscheck when creating particle list settings. Originally only particles of typeSimpleParticleTypewould be shown, because they implement bothParticleTypeandParticleOptions, however several other particles like potion swirls use a separateParticleOptionswhich would cause them to be droppedRelated, because block destroy particles were previously excluded by the filter, the dedicated setting has been removed to prefer using the particles setting. It also seems like the Flash particle type was hardcoded to always render during the 26.1.2 port but I was unable to find anywhere that depended on the particle being created, so I removed the block and it can be canceled properly
Related issues
N/A
How Has This Been Tested?
Compiled a list of every particle that was previously blocked, which includes:
And created commands blocks to spawn each, NoRender now keeps them from spawning:
8mb.video-5E1-rIzWERnC.mp4
Also played in normal anarchy server for ~1 hour and experienced no new bugs or weirdness
Checklist: