[WIP] refactor: unbloated color scheme settings for block ESP.#6233
Closed
Kiriyaga7615 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Closed
[WIP] refactor: unbloated color scheme settings for block ESP.#6233Kiriyaga7615 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Kiriyaga7615 wants to merge 1 commit intoMeteorDevelopment:masterfrom
Conversation
Kiriyaga7615
changed the title
Author
|
I think the BlockESP part of code is still bloated, and the way you cache ESPBlock and ESPBlockData separately is just wrong. Its on you if its ok or nah |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
there is 1364 survival obtainable items, and around 850-900 survival obtainable blocks for your museum, depending on what type of blocks youre going for in minecraft, and configuration of color scheme for each block is the most bloated thing i ever saw in minecraft clinets.
This PR removes color scheme configuration from both
StorageESPandBlockESPand uses MC API to get block color instead.Related issues
I didnt saw any
How Has This Been Tested?
Checklist: