fix: pass zoom param from embed URL to chart components#4350
Draft
SylvainChevalier wants to merge 1 commit intomainfrom
Draft
fix: pass zoom param from embed URL to chart components#4350SylvainChevalier wants to merge 1 commit intomainfrom
SylvainChevalier wants to merge 1 commit intomainfrom
Conversation
The embed modal correctly adds a zoom URL parameter to the iframe URL, but the embed page was not reading this parameter and passing it down to the chart components. This caused the zoom dropdown in the embed modal to have no effect on the rendered chart. Fixes #4332 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The embed modal correctly adds a
zoomURL parameter to the iframe URL, but the embed page was not reading this parameter and passing it down to the chart components. This caused the zoom dropdown in the embed modal to have no effect on the rendered chart.Fixes #4332
Generated with Claude Code