Fix: Show all subquestions in "Copy from" menu#4322
Open
SylvainChevalier wants to merge 3 commits intomainfrom
Open
Fix: Show all subquestions in "Copy from" menu#4322SylvainChevalier wants to merge 3 commits intomainfrom
SylvainChevalier wants to merge 3 commits intomainfrom
Conversation
Previously, the "Copy from" dropdown only showed open subquestions because all three copy operations (Copy to all, Copy to, Copy from) were using the same filtered list of openOptions. This fix adds a separate copyFromOptions prop to ForecastMakerGroupCopyMenu that receives all options (open, closed, and resolved), while maintaining the existing behavior for "Copy to" and "Copy to all" operations. Fixes #4260 Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
SylvainChevalier
temporarily deployed
to
testing_env
GitHub Actions
Inactive
Contributor
📝 WalkthroughWalkthroughAdded a new optional prop Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
SylvainChevalier
temporarily deployed
to
Preview
GitHub Actions
Inactive
Contributor
🚀 Preview EnvironmentYour preview environment is ready!
Details
ℹ️ Preview Environment InfoIsolation:
Limitations:
Cleanup:
|
Contributor
Author
|
"copy from" should be completely disabled on closed and resolved subquestions. "copy to" should be disabled when the user doesn't have a prediction. it should still be enabled when the user had a prediction but withdrew. |
|
Claude finished @SylvainChevalier's task in 3m 28s —— View job Implemented "Copy from" and "Copy to" menu behavior changes
SummaryPushed commit
|
- Disable Copy from items for closed and resolved subquestions - Disable Copy to and Copy to all when user has no prediction - Keep Copy to enabled when user had a prediction but withdrew Co-authored-by: Sylvain <SylvainChevalier@users.noreply.github.com>
Contributor
Author
|
@claude fix unit tests issues. |
|
Claude finished @SylvainChevalier's task in 4m 0s —— View job Fixed Prettier formatting issue
SummaryThe CI failure was a Prettier formatting issue (not a unit test failure). The - const canCopyFrom =
- option.hasUserForecast || option.wasWithdrawn;
+ const canCopyFrom = option.hasUserForecast || option.wasWithdrawn;Pushed commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the "Copy from" dropdown only showed open subquestions because all three copy operations (Copy to all, Copy to, Copy from) were using the same filtered list of openOptions.
This fix adds a separate copyFromOptions prop to ForecastMakerGroupCopyMenu that receives all options (open, closed, and resolved), while maintaining the existing behavior for "Copy to" and "Copy to all" operations.
Fixes #4260
Generated with Claude Code
Summary by CodeRabbit