Skip to content

Notebook edited_at adjustments #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
hlbmtc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Notebook edited_at adjustments #3975

hlbmtc wants to merge 2 commits into from

Conversation

@hlbmtc
Copy link
Contributor

@hlbmtc hlbmtc commented Dec 23, 2025

  • Removed automatic edited_at assignment for Notebooks. It’s now controlled manually in the update_notebook service.
  • Don’t set edited_at for unapproved notebooks. This avoids issues where auto-translation updates the edited date.
  • Updated the rendering logic for the edited_at field.
  • Added translations.

closes #3969

elisescu
elisescu approved these changes Dec 26, 2025
View reviewed changes
Copy link
Contributor

@elisescu elisescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elisescu elisescu elisescu approved these changes

@ncarazon ncarazon ncarazon approved these changes

@cemreinanc cemreinanc Awaiting requested review from cemreinanc

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Notebooks shouldn't mention they were edited if they were edited before they were approved

4 participants

@hlbmtc @elisescu @ncarazon