Skip to content

feat: build scripts with signed bundles android#884

Merged
coodos merged 1 commit intomainfrom
feat/keystore-signed-build
Feb 25, 2026
Merged

feat: build scripts with signed bundles android#884
coodos merged 1 commit intomainfrom
feat/keystore-signed-build

Conversation

@coodos
Copy link
Contributor

@coodos coodos commented Feb 25, 2026

Description of change

Issue Number

Type of change

  • Breaking (any change that would cause existing functionality to not work as expected)
  • New (a change which implements a new feature)
  • Update (a change which updates existing functionality)
  • Fix (a change which fixes an issue)
  • Docs (changes to the documentation)
  • Chore (refactoring, build scripts or anything else that isn't user-facing)

How the change has been tested

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

Summary by CodeRabbit

  • Chores
    • Updated build configuration to ignore keystore properties file.

@coodos coodos merged commit fbce5c6 into main Feb 25, 2026
3 checks passed
@coodos coodos deleted the feat/keystore-signed-build branch February 25, 2026 12:15
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 25, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f1012f4 and e9abca6.

⛔ Files ignored due to path filters (1)
  • infrastructure/eid-wallet/src-tauri/gen/android/app/build.gradle.kts is excluded by !**/gen/**
📒 Files selected for processing (1)
  • .gitignore

📝 Walkthrough

Walkthrough

The .gitignore file has been updated to exclude the keystore.properties file from version control, preventing sensitive keystore configuration from being committed to the repository.

Changes

Cohort / File(s) Summary
Git Configuration
.gitignore
Added keystore.properties to ignored files to prevent committing sensitive keystore configuration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A secret kept, a pattern new,
Keystores hidden, away from view,
Git ignores what must stay true,
Security blooms when files stay hidden too! 🔐

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/keystore-signed-build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant