-
-
Notifications
You must be signed in to change notification settings - Fork 188
make @metamask/vault-decryptor site publishable #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow is a bit different, it seems, from how we've set up Pages deployment for other repos (e.g. snap-account-abstraction-keyring). The way that these repos work is that when a new release is published, the site is deployed under both a v${version} directory as well as a latest directory: https://github.com/MetaMask/snap-account-abstraction-keyring/blob/145dca2d936a7617332cccbbe28dfbaf52f341fd/.github/workflows/publish-release.yml#L104. Also, the site is deployed for release candidate PRs under an rc-${version} directory: https://github.com/MetaMask/snap-account-abstraction-keyring/blob/145dca2d936a7617332cccbbe28dfbaf52f341fd/.github/workflows/publish-rc-dapp.yml.
Effectively, the site is versioned just like the package. Do we want to do that for this repo as well?
package.json
Outdated
| @@ -1,13 +1,17 @@ | |||
| { | |||
| "name": "@metamask/vault-decryptor", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that this PR is not just about making the site publishable, we are also making the package public as well. Do we want to set this version to 0.0.0? Otherwise, when we make a PR to release the package, the version won't be changed (or maybe it will, but it might go from 1.0.0 to something 0.1.0 which would be strange).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! Updated version to 0.0.0
Make @metamask/vault-decryptor site publishable.
Part of the larger effort to remove live requests from E2E tests: MMQA-273
JIRA task: MMQA-669
Note
Publishes the site via GitHub Pages and moves build artifacts into
dist/.Deploy to GitHub Pagesworkflow to build with Yarn and deploydist/on pushes tomasterpackage.jsonto build intodist/(browserifytodist/bundle.js, copyindex.html), addclean,build:clean, andprepublishOnlyscripts, includedist/in published files, and addrimrafdev dependencydist/to.gitignoreand updatesREADMEto documentdist/outputsWritten by Cursor Bugbot for commit ec94841. This will update automatically on new commits. Configure here.