Skip to content

Conversation

@Unik0rnMaggie
Copy link

@Unik0rnMaggie Unik0rnMaggie commented Jan 8, 2026

Make @metamask/vault-decryptor site publishable.

Part of the larger effort to remove live requests from E2E tests: MMQA-273

JIRA task: MMQA-669


Note

Publishes the site via GitHub Pages and moves build artifacts into dist/.

  • Adds Deploy to GitHub Pages workflow to build with Yarn and deploy dist/ on pushes to master
  • Updates package.json to build into dist/ (browserify to dist/bundle.js, copy index.html), add clean, build:clean, and prepublishOnly scripts, include dist/ in published files, and add rimraf dev dependency
  • Adds dist/ to .gitignore and updates README to document dist/ outputs

Written by Cursor Bugbot for commit ec94841. This will update automatically on new commits. Configure here.

@Unik0rnMaggie Unik0rnMaggie marked this pull request as ready for review January 12, 2026 13:53
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow is a bit different, it seems, from how we've set up Pages deployment for other repos (e.g. snap-account-abstraction-keyring). The way that these repos work is that when a new release is published, the site is deployed under both a v${version} directory as well as a latest directory: https://github.com/MetaMask/snap-account-abstraction-keyring/blob/145dca2d936a7617332cccbbe28dfbaf52f341fd/.github/workflows/publish-release.yml#L104. Also, the site is deployed for release candidate PRs under an rc-${version} directory: https://github.com/MetaMask/snap-account-abstraction-keyring/blob/145dca2d936a7617332cccbbe28dfbaf52f341fd/.github/workflows/publish-rc-dapp.yml.

Effectively, the site is versioned just like the package. Do we want to do that for this repo as well?

package.json Outdated
@@ -1,13 +1,17 @@
{
"name": "@metamask/vault-decryptor",
"version": "1.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this PR is not just about making the site publishable, we are also making the package public as well. Do we want to set this version to 0.0.0? Otherwise, when we make a PR to release the package, the version won't be changed (or maybe it will, but it might go from 1.0.0 to something 0.1.0 which would be strange).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! Updated version to 0.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants