fix: add case when json is invalid when uploading#83
Closed
montelaidev wants to merge 1 commit intomasterfrom
Closed
fix: add case when json is invalid when uploading#83montelaidev wants to merge 1 commit intomasterfrom
montelaidev wants to merge 1 commit intomasterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // attemp 6: When the backup file is not a valid json, it tries to extract the keyring controller object from the string. | ||
| { | ||
| const matches = data.match( | ||
| /(?<="KeyringController":)(.*?)(?=,"[a-zA-z]+":{)/ |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 11 months ago
To fix the problem, we need to correct the overly permissive regular expression range by specifying the correct ranges for uppercase and lowercase letters separately. This ensures that only the intended characters are matched.
- Replace the range
A-zwithA-Za-zto match only uppercase and lowercase alphabetical characters. - Update the regular expression on line 122 to use the corrected range.
Suggested changeset
1
app/lib.js
| @@ -121,3 +121,3 @@ | ||
| const matches = data.match( | ||
| /(?<="KeyringController":)(.*?)(?=,"[a-zA-z]+":{)/ | ||
| /(?<="KeyringController":)(.*?)(?=,"[a-zA-Za-z]+":{)/ | ||
| ); |
Copilot is powered by AI and may make mistakes. Always verify output.
Contributor
Author
|
Closed in favor of #82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.