Skip to content

Conversation

@hieu-w
Copy link
Contributor

@hieu-w hieu-w commented Jan 20, 2025

Motivation and Context

Jira Link:
https://toruslabs.atlassian.net/browse/PD-4301

Description

Update deps
Drop node 18 support
CI to node 22

How has this been tested?

npm run test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@hieu-w hieu-w self-assigned this Jan 20, 2025
@hieu-w hieu-w requested a review from chaitanyapotti March 14, 2025 02:12
this.verifierName = verifier;
this.verifierId = verifierId;
const { authConnectionId, userId } = obj.userInfo;
this.verifierName = authConnectionId;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename items to authConnectionId and userId.
remove all instances of verifier

@hieu-w hieu-w force-pushed the feat/PD-4301-Stack-upgrade branch from a51b14d to 08a570a Compare March 14, 2025 04:29
"@toruslabs/rss-client": "^2.0.1",
"@toruslabs/torus.js": "^15.1.0",
"@types/bn.js": "^5.1.5",
"@tkey/common-types": "../common-types",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

undo this

Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 2add4fb into master Mar 14, 2025
1 check passed
@chaitanyapotti chaitanyapotti deleted the feat/PD-4301-Stack-upgrade branch March 14, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants