fix: input share store unrelated share inputs #210
Conversation
packages/core/src/core.ts
Outdated
| } else { | ||
| throw CoreError.default("can only add type ShareStore into shares"); | ||
| } | ||
| ss = this.metadata.shareToShareStore(ss.share.share as BN); |
There was a problem hiding this comment.
would we have simpler check if we check for existence of the input shareStore's polyID in the polyIDList ?
@metallicalfa2
also, should we add check for the inputShareStore that the polyID should be the latest polyID?
There was a problem hiding this comment.
I think the shareToShareStore won't fix the issue properly.
we should check the if latest share's metadata polynomial has the current tkey latest polynomial.
There was a problem hiding this comment.
negative test cases are working fine, can you explain which case can fail
https://github.com/tkey/tkey/pull/210/files#diff-d264ebdc71dfea141ff0afde527572308cf1712526e641e7598b4e56ca3e4780R896-R899
There was a problem hiding this comment.
Possible scenario,
create 2 tkey instance, InstA, InstB
InstB generate new share E,
input share E to tkey InstA.
shareToShareStore would failed as share E is not expected in InstA metadata
No description provided.