Feat/remove opinionated storage #202
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
== Breaking ==
Tkey should not be opinionated on how the device share is being stored.
remove the storeDeviceShare, the deviceShare can be coded outside tkey.
Example webstorage code implementation
I think passing the tkey instance in to the webStorage function would make more clear and prevent mistake.
But the webstorage API will need to change (refactor).
https://github.com/tkey/tkey/tree/feat/refactorWebStorage
example