generated from MetaMask/metamask-module-template
-
Notifications
You must be signed in to change notification settings - Fork 7
fix: Update postinstall scripts to check DEPENDABOT variable #782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f4762de
fix: Update postinstall scripts to check DEPENDABOT variable
rekmarks 64f16da
fix(ci): Remove PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD from test job
rekmarks 927c0cf
fix(ci): Use minimal headless browser in CI
rekmarks 6383e8f
fix(ci): Install full Chromium for e2e tests
rekmarks d42adc1
fix(ci): Use headless shell for unit tests, full browser for e2e
rekmarks 0769b3c
fix(ci): Add GITHUB_ACTOR fallback for Dependabot detection
rekmarks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,25 @@ | ||
| #!/bin/bash | ||
|
|
||
| # Skip in Dependabot PRs (native builds aren't needed and may fail) | ||
| if [ "$GITHUB_ACTOR" = "dependabot[bot]" ]; then | ||
| echo "⏭️ Skipping native rebuild in Dependabot PR" | ||
| # Skip in Dependabot environments (not needed and causes failures) | ||
| # DEPENDABOT is set in the updater environment, GITHUB_ACTOR in PR workflows | ||
| if [ -n "$DEPENDABOT" ] || [ "$GITHUB_ACTOR" = "dependabot[bot]" ]; then | ||
| echo "⏭️ Skipping Playwright install in Dependabot environment" | ||
rekmarks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| exit 0 | ||
| fi | ||
|
|
||
| yarn playwright install chromium | ||
| # Also respect PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD for CI environments | ||
| if [ "$PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD" = "1" ]; then | ||
| echo "⏭️ Skipping Playwright install (PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1)" | ||
| exit 0 | ||
| fi | ||
|
|
||
| # Install Chromium (with system deps in CI, headless shell only if requested) | ||
| if [ "$CI" = "true" ]; then | ||
| if [ "$PLAYWRIGHT_ONLY_SHELL" = "1" ]; then | ||
| yarn playwright install --with-deps --only-shell chromium | ||
rekmarks marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| else | ||
| yarn playwright install --with-deps chromium | ||
| fi | ||
| else | ||
| yarn playwright install chromium | ||
| fi | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.