Skip to content

chore: bump @metamask/transaction-controller and @metamask/transaction-pay-controller#28804

Merged
dan437 merged 2 commits intomainfrom
txc-and-tpc-version-bump
Apr 14, 2026
Merged

chore: bump @metamask/transaction-controller and @metamask/transaction-pay-controller#28804
dan437 merged 2 commits intomainfrom
txc-and-tpc-version-bump

Conversation

@dan437
Copy link
Copy Markdown
Contributor

@dan437 dan437 commented Apr 14, 2026

Description

Bump @metamask/transaction-controller from ^64.0.0 to ^64.2.0 and @metamask/transaction-pay-controller from ^19.1.0 to ^19.1.1.

Core PR: MetaMask/core#8447

Changelog

CHANGELOG entry: null

Related issues

Fixes: CONF-1158

Manual testing steps

Feature: mm_pay_time_to_complete_s accuracy

  Scenario: Perps withdraw reports realistic time
    Given the user has a Hyperliquid perps position

    When user initiates a perps withdraw
    Then Transaction Finalized event contains mm_pay_time_to_complete_s > 1s

  Scenario: Perps deposit reports realistic time
    Given the user has funds available for a perps deposit

    When user initiates a perps deposit
    Then Transaction Finalized event contains mm_pay_time_to_complete_s > 1s

  Scenario: Predict withdraw reports realistic time
    Given the user has a predict position to withdraw

    When user initiates a predict withdraw
    Then Transaction Finalized event contains mm_pay_time_to_complete_s > 1s

Screenshots/Recordings

N/A — metric-only change, no UI impact.

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Updates core transaction/payment controller dependencies, which can affect transaction lifecycle behavior and related metrics. Risk is moderate because changes are pulled in via upstream packages rather than local code edits.

Overview
Updates dependencies to @metamask/transaction-controller@^64.2.0 (from ^64.0.0) and @metamask/transaction-pay-controller@^19.1.1 (from ^19.1.0).

Regenerates yarn.lock to reflect the new transitive graph, including a bump of @metamask/ramps-controller to 13.1.0 and updated internal controller dependencies (e.g., @metamask/accounts-controller, @metamask/messenger).

Reviewed by Cursor Bugbot for commit 30db948. Bugbot is set up for automated code reviews on this repo. Configure here.

…n-pay-controller

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Apr 14, 2026
@github-actions github-actions bot added risk-high Extensive testing required · High bug introduction risk size-XS labels Apr 14, 2026
@socket-security
Copy link
Copy Markdown

socket-security bot commented Apr 14, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​ramps-controller@​13.0.0 ⏵ 13.1.0961007898 +1100
Updatednpm/​@​metamask/​transaction-pay-controller@​19.1.0 ⏵ 19.1.198 +110080 +199 +1100

View full report

Signed-off-by: dan437 <80175477+dan437@users.noreply.github.com>
@github-actions github-actions bot added risk-high Extensive testing required · High bug introduction risk and removed risk-high Extensive testing required · High bug introduction risk labels Apr 14, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeTrade, SmokeWalletPlatform, SmokeCard, SmokePerps, SmokeRamps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, FlaskBuildTests
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-controller, @metamask/transaction-pay-controller. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/transaction-controller, @metamask/transaction-pay-controller. Running all tests.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

@dan437 dan437 enabled auto-merge April 14, 2026 12:28
@github-actions
Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@dan437 dan437 added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 6a98fbb Apr 14, 2026
113 checks passed
@dan437 dan437 deleted the txc-and-tpc-version-bump branch April 14, 2026 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-high Extensive testing required · High bug introduction risk size-XS team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants