chore: update config mappings, promote Modal* migration targets to complete#62
Draft
AndyMBridges wants to merge 1 commit into
Draft
chore: update config mappings, promote Modal* migration targets to complete#62AndyMBridges wants to merge 1 commit into
AndyMBridges wants to merge 1 commit into
Conversation
…d auto-promotion to sync-config, remove May 1 metrics - config.json: map ModalFooter and ModalFocus to @metamask/design-system-react; update Skeleton mobile replacement - scripts/sync-config.js: auto-promote migration-targets to complete when component lands in MMDS - metrics/migration-targets.json: promote ModalBody, ModalFocus, ModalFooter, ModalOverlay to complete (31/48 extension) - Remove May 1 metric data files from metrics/ and dashboard/public/metrics/ - Trim timeline.json and index.json back to Apr 24 (CI will regenerate May 5 via workflow_dispatch) Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.json: MapsModalFooterandModalFocusto@metamask/design-system-react(discovered bysync-configfrom the latest design-system repo); updatesSkeletonmobile replacementscripts/sync-config.js: Adds auto-promotion logic — anyto_doentry inmigration-targets.jsonis automatically flipped tocompletewhen the component appears in the MMDS component list, so this never drifts againmetrics/migration-targets.json+dashboard/public/metrics/migration-targets.json: PromotesModalBody,ModalFocus,ModalFooter,ModalOverlaytocomplete(extension now 31/48)metrics/anddashboard/public/metrics/timeline.jsonandindex.jsonback to Apr 24 as the latest data pointWhy metrics were removed
May 1 data was generated against stale repo snapshots. After merging this PR, trigger the
weekly-metricsworkflow viaworkflow_dispatchto regenerate fresh metrics from latest main of all repos and deploy to production.Test plan
yarn validate-metricspasses after mergeworkflow_dispatchonweekly-metrics.ymlto generate fresh metricsMade with Cursor