Skip to content

feat: add agentic cli preferences#8933

Draft
ieow wants to merge 1 commit into
mainfrom
cw/agentic-cli-notification-preference
Draft

feat: add agentic cli preferences#8933
ieow wants to merge 1 commit into
mainfrom
cw/agentic-cli-notification-preference

Conversation

@ieow
Copy link
Copy Markdown
Contributor

@ieow ieow commented May 29, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Extending NotificationPreferences with a new required field is a breaking type change for consumers that build or spread preference objects without agenticCli.

Overview
Adds agentic CLI notification settings to authenticated user storage: a new AgenticCliPreference type (in-app and push toggles) and a required agenticCli field on NotificationPreferences.

Test mocks were updated so MOCK_NOTIFICATION_PREFERENCES includes sample agenticCli values.

Reviewed by Cursor Bugbot for commit a732e09. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a732e09. Configure here.

marketing: MarketingPreference;
perps: PerpsPreference;
socialAI: SocialAIPreference;
agenticCli: AgenticCliPreference;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validation schema missing new agenticCli field

High Severity

The NotificationPreferences type now requires agenticCli, but NotificationPreferencesSchema in validators.ts was not updated to include a corresponding agenticCli field. The assertNotificationPreferences function uses this schema to validate API responses, then asserts the data is NotificationPreferences. This means API data missing agenticCli will pass validation, yet downstream code will trust it's present — causing runtime undefined access errors.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit a732e09. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant