feat(wallet-cli): Add wallet CLI with daemon support by rekmarks · Pull Request #8446 · MetaMask/core

rekmarks · 2026-04-14T04:16:36Z

Introduces an oclif CLI for @metamask/wallet. It is more or less a port of the Ocap Kernel equivalent.

Usage

First, cd packages/wallet-cli.

Then, to start the daemon:

yarn mm daemon start \
  --infura-project-id <YOUR_PROJECT_ID> \
  --password testpass \
  --srp 'test test test test test test test test test test test ball'

Try calling an available controller action:

yarn mm daemon call AccountsController:listAccounts

Actions params must be specified as a stringified JSON array:

yarn mm daemon call \
    KeyringController:signPersonalMessage \
    '[{"data": "0x48656c6c6f2c20776f726c6421", "from": "0xc6d5a3c98ec9073b54fa0969957bd582e8d874bf"}]'

When done, stop the daemon and clean up:

yarn mm daemon purge --force

Summary

Create wallet-cli package scaffolded with oclif (mm binary)
Implement daemon infrastructure for running a @metamask/wallet instance as a detached background process, communicating over JSON-RPC via Unix domain sockets
Add daemon commands: start, stop, status, purge, call
call command dispatches arbitrary messenger actions to the running daemon (e.g. mm daemon call AccountsController:listAccounts)
Unit tests for all daemon modules (108 tests, 100% coverage on daemon code)

Note

High Risk
Adds a new CLI/daemon that starts a wallet instance and exposes arbitrary messenger actions over a local Unix socket, plus lifecycle management (spawn/stop/purge); mistakes here could impact key handling and local security expectations.

Overview
Introduces a new @metamask/wallet-cli package (Oclif mm binary) that can spawn and manage a detached wallet daemon and communicate with it over newline-delimited JSON-RPC on a Unix domain socket.

Implements daemon lifecycle and RPC plumbing: a socket server with getStatus, shutdown, and a generic call method that forwards arbitrary messenger action names/args, along with CLI commands daemon start|stop|status|purge|call and supporting utilities/tests.

Wires the package into the monorepo (TypeScript refs, ESLint overrides, README dependency graph, CODEOWNERS/teams.json, Yarn workspace rules/lockfile), and exports importSecretRecoveryPhrase from @metamask/wallet for daemon initialization.

^{Reviewed by Cursor Bugbot for commit f69d1cc. Bugbot is set up for automated code reviews on this repo. Configure here.}

socket-security · 2026-04-14T04:17:31Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	@inquirer/confirm@6.0.7 ⏵ 6.0.11	⁺¹			^-1
	@oclif/core@4.10.5

View full report

packages/wallet-cli/src/daemon/stop-daemon.ts

packages/wallet-cli/src/daemon/utils.ts

packages/wallet-cli/src/daemon/rpc-socket-server.ts

packages/wallet-cli/src/index.ts

packages/wallet-cli/src/commands/daemon/start.ts

packages/wallet-cli/src/daemon/daemon-spawn.ts

packages/wallet-cli/src/daemon/daemon-entry.ts

packages/wallet-cli/src/daemon/daemon-spawn.ts

packages/wallet-cli/src/daemon/daemon-entry.ts

packages/wallet-cli/src/daemon/rpc-socket-server.ts

packages/wallet-cli/typedoc.json

packages/wallet-cli/src/daemon/stop-daemon.ts

packages/wallet-cli/src/daemon/daemon-entry.ts

…rocess Adds a daemon that runs a Wallet instance as a detached background process, communicating over JSON-RPC via Unix domain sockets. This mirrors the architecture of kernel-cli's daemon. Infrastructure (src/daemon/): - socket-line: newline-delimited socket I/O - rpc-socket-server: generic Unix socket JSON-RPC server - daemon-client: one-shot JSON-RPC client with retry - daemon-entry: standalone entry point for the spawned process - daemon-spawn: spawns daemon-entry as detached child - stop-daemon: shared stop logic with escalation - wallet-factory: creates configured Wallet from config - utils, paths, types: process utilities and path resolution Commands (src/commands/daemon/): - start: start daemon (--infura-project-id or INFURA_PROJECT_ID env) - stop: stop daemon (RPC shutdown -> SIGTERM -> SIGKILL) - status: check daemon status - purge: stop daemon and delete all state files Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

9 test files covering all daemon infrastructure: paths, socket-line, utils, rpc-socket-server, daemon-client, stop-daemon, wallet-factory, daemon-entry, and daemon-spawn. 96 tests total. Config changes: - jest.config.js: exclude commands/ from coverage (not yet tested) - eslint.config.mjs: disable n/no-process-env and n/no-sync for wallet-cli test files Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Wire sendSignal into stopDaemon so EPERM errors from process.kill are not silently treated as successful stops. Remove unused withTimeout utility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Thread wallet password and secret recovery phrase through the daemon startup chain so the wallet is initialized with an imported SRP. - Export importSecretRecoveryPhrase from @metamask/wallet - Add --password and --srp required flags to `daemon start` - Pass MM_WALLET_PASSWORD / MM_WALLET_SRP env vars to spawned daemon - Make createWallet async; call importSecretRecoveryPhrase after init Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Adds a `daemon call` CLI command that forwards arbitrary messenger action calls to the running wallet daemon over JSON-RPC. The daemon registers a `call` RPC handler that invokes `wallet.messenger.call()` with the provided action name and arguments. Usage: wallet-cli daemon call AccountsController:listAccounts wallet-cli daemon call NetworkController:getState --timeout 10000 Also fixes lint errors in wallet-factory.ts (missing return types). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Remove placeholder index.ts and library exports (CLI-only package) - Add yarn constraints exception for wallet-cli exports - Document intentional `as any` messenger dispatch in daemon-entry - Remove duplicate socketPath param from ensureDaemon - Remove unused logPath from DaemonSpawnConfig - Add 30s server-side socket read timeout in rpc-socket-server - Handle sendCommand throwing in status command - Have purge remove entire data directory - Tighten isRpcError to require both code and message - Fix waitFor to return false on timeout instead of re-checking - Clarify multi-request rejection test assertions - Document password/srp CLI flags as testing-only Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Destructuring null params (when a request omits the params field) would throw a confusing TypeError. Add a runtime check that params is a non-empty array before destructuring. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

packages/wallet-cli/src/daemon/rpc-socket-server.ts

rekmarks · 2026-04-14T20:29:39Z

@SocketSecurity ignore npm/jake@10.9.4

Transitive via @oclif/core. Usage not suspicious.

… typedoc and JSDoc - Await rm calls in shutdown finally block via Promise.all and in error cleanup path so callers know cleanup is complete - Use rpcErrors.parse() (-32700) for JSON.parse failures per JSON-RPC spec - Update typedoc.json entry points after index.ts removal - Move CONNECTION_TIMEOUT_MS above JSDoc so doc attaches to the function Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Reject params where the first element is not a string, preventing confusing downstream errors from messenger.call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 5951891. Configure here.}

packages/wallet-cli/src/daemon/daemon-entry.ts

- Log errors in catch blocks instead of silently swallowing them across daemon-entry, stop-daemon, and rpc-socket-server - Make shutdown cleanup independent: handle.close(), wallet.destroy(), and file removal each run in their own try/catch so one failure doesn't skip the others - Add default 30s timeout to sendCommand to prevent indefinite hangs - Use JsonRpcResponse from @metamask/utils as handleRequest return type - Add shared DaemonStatusInfo type for the getStatus RPC contract - Change RpcHandler to allow void return, document null params - Filter expected socket errors (EPIPE/ECONNRESET), log unexpected ones - Only suppress ENOENT in socket unlink, re-throw other errors - Clean up socket file (not just PID file) when stopDaemon succeeds - Add child.on('error') handler in daemon-spawn for spawn failures - Switch makeLogger from sync appendFileSync to async appendFile - Remove socketPath from DaemonSpawnConfig, derive from dataDir - Include error details in status command catch block Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Replace the required --force flag with an interactive y/N confirmation prompt using @inquirer/confirm. The --force flag now skips the prompt instead of being mandatory. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

This comment was marked as resolved.

Sign in to view

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/daemon/rpc-socket-server.ts Show resolved Hide resolved

packages/wallet-cli/src/index.ts Outdated Show resolved Hide resolved

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/commands/daemon/start.ts Show resolved Hide resolved

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/daemon/daemon-spawn.ts Show resolved Hide resolved

packages/wallet-cli/src/daemon/daemon-entry.ts Show resolved Hide resolved

rekmarks requested a review from a team as a code owner April 14, 2026 05:34

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/daemon/daemon-spawn.ts Show resolved Hide resolved

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/daemon/daemon-entry.ts Outdated Show resolved Hide resolved

packages/wallet-cli/src/daemon/rpc-socket-server.ts Show resolved Hide resolved

rekmarks added the no-changelog label Apr 14, 2026

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/typedoc.json Outdated Show resolved Hide resolved

packages/wallet-cli/src/daemon/stop-daemon.ts Show resolved Hide resolved

packages/wallet-cli/src/daemon/daemon-entry.ts Show resolved Hide resolved

Base automatically changed from rekm/wallet-library-tweaks to feat/wallet-library April 14, 2026 10:50

rekmarks and others added 14 commits April 14, 2026 13:09

chore: Create wallet-cli package

52623e2

chore: oclif init

c8c6715

fix: Fix error serialization in rpc socket server

3b5e6fa

fix(wallet-cli): Use sendSignal in stopDaemon, remove dead withTimeout

047087d

Wire sendSignal into stopDaemon so EPERM errors from process.kill are not silently treated as successful stops. Remove unused withTimeout utility. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

chore: Fix codeowners

2e9c53c

chore: yarn dedupe

ab0ed78

docs: Update readme dep graph

c1eb9f6

chore: prettier

1c1a4bf

rekmarks force-pushed the rekm/wallet-cli branch from 98a9392 to 1c1a4bf Compare April 14, 2026 20:09

chore: Update teams.json and sync with CODEOWNERS

f3db6b7

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/daemon/rpc-socket-server.ts Outdated Show resolved Hide resolved

rekmarks and others added 2 commits April 14, 2026 13:38

fix(wallet-cli): Validate action name is a string in call handler

5951891

Reject params where the first element is not a string, preventing confusing downstream errors from messenger.call. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

cursor bot reviewed Apr 14, 2026

View reviewed changes

packages/wallet-cli/src/daemon/daemon-entry.ts Show resolved Hide resolved

rekmarks and others added 4 commits April 14, 2026 14:16

chore: lint dependencies

7ded3ef

chore: Fix wallet-cli test coverage

f69d1cc

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(wallet-cli): Add wallet CLI with daemon support#8446

feat(wallet-cli): Add wallet CLI with daemon support#8446
rekmarks wants to merge 21 commits intofeat/wallet-libraryfrom
rekm/wallet-cli

rekmarks commented Apr 14, 2026 •

edited by cursor bot

Loading

Uh oh!

socket-security bot commented Apr 14, 2026 •

edited

Loading

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rekmarks commented Apr 14, 2026

Uh oh!

cursor bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

rekmarks commented Apr 14, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Usage

Summary

Uh oh!

socket-security bot commented Apr 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rekmarks commented Apr 14, 2026

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

rekmarks commented Apr 14, 2026 •

edited by cursor bot

Loading

socket-security bot commented Apr 14, 2026 •

edited

Loading