Draft
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Mrtenz
added a commit
to MetaMask/auto-changelog
that referenced
this pull request
Apr 13, 2026
This adds a new `--formatter` option, which can be set to either "prettier" or "oxfmt", and deprecates the `--prettier` option. I've also refactored the logic to load Prettier dynamically, so both Oxfmt and Prettier are now _optional_ peer dependencies. Tested in `MetaMask/core`: - MetaMask/core#8442 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Moderate risk: changes CLI flags and formatting behavior via dynamic imports, which could affect consumers relying on the deprecated `--prettier` flag or missing optional peer deps at runtime. > > **Overview** > Adds a new `--formatter` CLI option to choose changelog formatting (`prettier` or `oxfmt`, with `none` for `validate`) and deprecates the legacy `--prettier` flag (which still takes precedence when provided). > > Refactors changelog formatting to route through new `src/formatters.ts` helpers that dynamically import Prettier/Oxfmt and throw clearer errors when the chosen formatter isn’t installed, and updates tests and package metadata to treat `prettier`/`oxfmt` as *optional* peer dependencies. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b0fc35a. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This updates changelog validation to use Oxfmt instead of Prettier.
References
Checklist