Skip to content

add money account upgrade controller#8426

Draft
Jwhiles wants to merge 7 commits intoadd-chomp-apifrom
add-money-account-upgrade-controller
Draft

add money account upgrade controller#8426
Jwhiles wants to merge 7 commits intoadd-chomp-apifrom
add-money-account-upgrade-controller

Conversation

@Jwhiles
Copy link
Copy Markdown

@Jwhiles Jwhiles commented Apr 10, 2026

Explanation

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@Jwhiles Jwhiles changed the base branch from main to add-chomp-api April 10, 2026 16:01
async #verifyDelegation(address: Hex, chainId: Hex): Promise<void> {
const salt: Hex = `0x${Array.from(
// TODO: do I need to read this off of globalThis?
globalThis.crypto.getRandomValues(new Uint8Array(32)),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the other packages do

import { webcrypto } from 'node:crypto';

@Jwhiles Jwhiles force-pushed the add-chomp-api branch 4 times, most recently from d8926ef to 010ce60 Compare April 14, 2026 15:22
@Jwhiles Jwhiles force-pushed the add-money-account-upgrade-controller branch 4 times, most recently from 24eee6b to 8b2387c Compare April 14, 2026 18:49
@Jwhiles Jwhiles force-pushed the add-money-account-upgrade-controller branch from 8b2387c to 2e23109 Compare April 14, 2026 18:53
@Jwhiles
Copy link
Copy Markdown
Author

Jwhiles commented Apr 14, 2026

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@7.0.0-preview-2e231093e
@metamask-previews/accounts-controller@37.2.0-preview-2e231093e
@metamask-previews/address-book-controller@7.1.1-preview-2e231093e
@metamask-previews/ai-controllers@0.6.3-preview-2e231093e
@metamask-previews/analytics-controller@1.0.1-preview-2e231093e
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-2e231093e
@metamask-previews/announcement-controller@8.1.0-preview-2e231093e
@metamask-previews/app-metadata-controller@2.0.1-preview-2e231093e
@metamask-previews/approval-controller@9.0.1-preview-2e231093e
@metamask-previews/assets-controller@5.0.0-preview-2e231093e
@metamask-previews/assets-controllers@103.1.1-preview-2e231093e
@metamask-previews/base-controller@9.0.1-preview-2e231093e
@metamask-previews/base-data-service@0.1.1-preview-2e231093e
@metamask-previews/bridge-controller@70.0.1-preview-2e231093e
@metamask-previews/bridge-status-controller@70.0.5-preview-2e231093e
@metamask-previews/build-utils@3.0.4-preview-2e231093e
@metamask-previews/chain-agnostic-permission@1.5.0-preview-2e231093e
@metamask-previews/chomp-api-service@0.0.0-preview-2e231093e
@metamask-previews/claims-controller@0.5.0-preview-2e231093e
@metamask-previews/client-controller@1.0.1-preview-2e231093e
@metamask-previews/compliance-controller@2.0.0-preview-2e231093e
@metamask-previews/composable-controller@12.0.1-preview-2e231093e
@metamask-previews/config-registry-controller@0.2.0-preview-2e231093e
@metamask-previews/connectivity-controller@0.2.0-preview-2e231093e
@metamask-previews/controller-utils@11.20.0-preview-2e231093e
@metamask-previews/core-backend@6.2.1-preview-2e231093e
@metamask-previews/delegation-controller@3.0.0-preview-2e231093e
@metamask-previews/earn-controller@12.0.0-preview-2e231093e
@metamask-previews/eip-5792-middleware@3.0.3-preview-2e231093e
@metamask-previews/eip-7702-internal-rpc-middleware@0.1.0-preview-2e231093e
@metamask-previews/eip1193-permission-middleware@1.0.3-preview-2e231093e
@metamask-previews/ens-controller@19.1.1-preview-2e231093e
@metamask-previews/eth-block-tracker@15.0.1-preview-2e231093e
@metamask-previews/eth-json-rpc-middleware@23.1.1-preview-2e231093e
@metamask-previews/eth-json-rpc-provider@6.0.1-preview-2e231093e
@metamask-previews/foundryup@1.0.1-preview-2e231093e
@metamask-previews/gas-fee-controller@26.1.1-preview-2e231093e
@metamask-previews/gator-permissions-controller@3.0.1-preview-2e231093e
@metamask-previews/geolocation-controller@0.1.2-preview-2e231093e
@metamask-previews/json-rpc-engine@10.2.4-preview-2e231093e
@metamask-previews/json-rpc-middleware-stream@8.0.8-preview-2e231093e
@metamask-previews/keyring-controller@25.2.0-preview-2e231093e
@metamask-previews/logging-controller@8.0.1-preview-2e231093e
@metamask-previews/message-manager@14.1.1-preview-2e231093e
@metamask-previews/messenger@1.1.1-preview-2e231093e
@metamask-previews/messenger-cli@0.1.0-preview-2e231093e
@metamask-previews/money-account-controller@0.1.0-preview-2e231093e
@metamask-previews/money-account-upgrade-controller@0.1.0-preview-2e231093e
@metamask-previews/multichain-account-service@8.0.1-preview-2e231093e
@metamask-previews/multichain-api-middleware@2.0.0-preview-2e231093e
@metamask-previews/multichain-network-controller@3.0.6-preview-2e231093e
@metamask-previews/multichain-transactions-controller@7.0.4-preview-2e231093e
@metamask-previews/name-controller@9.1.1-preview-2e231093e
@metamask-previews/network-controller@30.0.1-preview-2e231093e
@metamask-previews/network-enablement-controller@5.0.2-preview-2e231093e
@metamask-previews/notification-services-controller@23.0.1-preview-2e231093e
@metamask-previews/permission-controller@12.3.0-preview-2e231093e
@metamask-previews/permission-log-controller@5.1.0-preview-2e231093e
@metamask-previews/perps-controller@3.0.0-preview-2e231093e
@metamask-previews/phishing-controller@17.1.1-preview-2e231093e
@metamask-previews/polling-controller@16.0.4-preview-2e231093e
@metamask-previews/preferences-controller@23.1.0-preview-2e231093e
@metamask-previews/profile-metrics-controller@3.1.3-preview-2e231093e
@metamask-previews/profile-sync-controller@28.0.2-preview-2e231093e
@metamask-previews/ramps-controller@13.1.0-preview-2e231093e
@metamask-previews/rate-limit-controller@7.0.1-preview-2e231093e
@metamask-previews/react-data-query@0.2.0-preview-2e231093e
@metamask-previews/remote-feature-flag-controller@4.2.0-preview-2e231093e
@metamask-previews/sample-controllers@4.0.4-preview-2e231093e
@metamask-previews/seedless-onboarding-controller@9.1.0-preview-2e231093e
@metamask-previews/selected-network-controller@26.1.0-preview-2e231093e
@metamask-previews/shield-controller@5.1.1-preview-2e231093e
@metamask-previews/signature-controller@39.1.2-preview-2e231093e
@metamask-previews/social-controllers@0.1.0-preview-2e231093e
@metamask-previews/storage-service@1.0.1-preview-2e231093e
@metamask-previews/subscription-controller@6.1.2-preview-2e231093e
@metamask-previews/transaction-controller@64.2.0-preview-2e231093e
@metamask-previews/transaction-pay-controller@19.1.1-preview-2e231093e
@metamask-previews/user-operation-controller@41.2.0-preview-2e231093e

@Jwhiles
Copy link
Copy Markdown
Author

Jwhiles commented Apr 14, 2026

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@7.0.0-preview-7bb388270
@metamask-previews/accounts-controller@37.2.0-preview-7bb388270
@metamask-previews/address-book-controller@7.1.1-preview-7bb388270
@metamask-previews/ai-controllers@0.6.3-preview-7bb388270
@metamask-previews/analytics-controller@1.0.1-preview-7bb388270
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-7bb388270
@metamask-previews/announcement-controller@8.1.0-preview-7bb388270
@metamask-previews/app-metadata-controller@2.0.1-preview-7bb388270
@metamask-previews/approval-controller@9.0.1-preview-7bb388270
@metamask-previews/assets-controller@5.0.0-preview-7bb388270
@metamask-previews/assets-controllers@103.1.1-preview-7bb388270
@metamask-previews/base-controller@9.0.1-preview-7bb388270
@metamask-previews/base-data-service@0.1.1-preview-7bb388270
@metamask-previews/bridge-controller@70.0.1-preview-7bb388270
@metamask-previews/bridge-status-controller@70.0.5-preview-7bb388270
@metamask-previews/build-utils@3.0.4-preview-7bb388270
@metamask-previews/chain-agnostic-permission@1.5.0-preview-7bb388270
@metamask-previews/chomp-api-service@0.0.0-preview-7bb388270
@metamask-previews/claims-controller@0.5.0-preview-7bb388270
@metamask-previews/client-controller@1.0.1-preview-7bb388270
@metamask-previews/compliance-controller@2.0.0-preview-7bb388270
@metamask-previews/composable-controller@12.0.1-preview-7bb388270
@metamask-previews/config-registry-controller@0.2.0-preview-7bb388270
@metamask-previews/connectivity-controller@0.2.0-preview-7bb388270
@metamask-previews/controller-utils@11.20.0-preview-7bb388270
@metamask-previews/core-backend@6.2.1-preview-7bb388270
@metamask-previews/delegation-controller@3.0.0-preview-7bb388270
@metamask-previews/earn-controller@12.0.0-preview-7bb388270
@metamask-previews/eip-5792-middleware@3.0.3-preview-7bb388270
@metamask-previews/eip-7702-internal-rpc-middleware@0.1.0-preview-7bb388270
@metamask-previews/eip1193-permission-middleware@1.0.3-preview-7bb388270
@metamask-previews/ens-controller@19.1.1-preview-7bb388270
@metamask-previews/eth-block-tracker@15.0.1-preview-7bb388270
@metamask-previews/eth-json-rpc-middleware@23.1.1-preview-7bb388270
@metamask-previews/eth-json-rpc-provider@6.0.1-preview-7bb388270
@metamask-previews/foundryup@1.0.1-preview-7bb388270
@metamask-previews/gas-fee-controller@26.1.1-preview-7bb388270
@metamask-previews/gator-permissions-controller@3.0.1-preview-7bb388270
@metamask-previews/geolocation-controller@0.1.2-preview-7bb388270
@metamask-previews/json-rpc-engine@10.2.4-preview-7bb388270
@metamask-previews/json-rpc-middleware-stream@8.0.8-preview-7bb388270
@metamask-previews/keyring-controller@25.2.0-preview-7bb388270
@metamask-previews/logging-controller@8.0.1-preview-7bb388270
@metamask-previews/message-manager@14.1.1-preview-7bb388270
@metamask-previews/messenger@1.1.1-preview-7bb388270
@metamask-previews/messenger-cli@0.1.0-preview-7bb388270
@metamask-previews/money-account-controller@0.1.0-preview-7bb388270
@metamask-previews/money-account-upgrade-controller@0.1.0-preview-7bb388270
@metamask-previews/multichain-account-service@8.0.1-preview-7bb388270
@metamask-previews/multichain-api-middleware@2.0.0-preview-7bb388270
@metamask-previews/multichain-network-controller@3.0.6-preview-7bb388270
@metamask-previews/multichain-transactions-controller@7.0.4-preview-7bb388270
@metamask-previews/name-controller@9.1.1-preview-7bb388270
@metamask-previews/network-controller@30.0.1-preview-7bb388270
@metamask-previews/network-enablement-controller@5.0.2-preview-7bb388270
@metamask-previews/notification-services-controller@23.0.1-preview-7bb388270
@metamask-previews/permission-controller@12.3.0-preview-7bb388270
@metamask-previews/permission-log-controller@5.1.0-preview-7bb388270
@metamask-previews/perps-controller@3.0.0-preview-7bb388270
@metamask-previews/phishing-controller@17.1.1-preview-7bb388270
@metamask-previews/polling-controller@16.0.4-preview-7bb388270
@metamask-previews/preferences-controller@23.1.0-preview-7bb388270
@metamask-previews/profile-metrics-controller@3.1.3-preview-7bb388270
@metamask-previews/profile-sync-controller@28.0.2-preview-7bb388270
@metamask-previews/ramps-controller@13.1.0-preview-7bb388270
@metamask-previews/rate-limit-controller@7.0.1-preview-7bb388270
@metamask-previews/react-data-query@0.2.0-preview-7bb388270
@metamask-previews/remote-feature-flag-controller@4.2.0-preview-7bb388270
@metamask-previews/sample-controllers@4.0.4-preview-7bb388270
@metamask-previews/seedless-onboarding-controller@9.1.0-preview-7bb388270
@metamask-previews/selected-network-controller@26.1.0-preview-7bb388270
@metamask-previews/shield-controller@5.1.1-preview-7bb388270
@metamask-previews/signature-controller@39.1.2-preview-7bb388270
@metamask-previews/social-controllers@0.1.0-preview-7bb388270
@metamask-previews/storage-service@1.0.1-preview-7bb388270
@metamask-previews/subscription-controller@6.1.2-preview-7bb388270
@metamask-previews/transaction-controller@64.2.0-preview-7bb388270
@metamask-previews/transaction-pay-controller@19.1.1-preview-7bb388270
@metamask-previews/user-operation-controller@41.2.0-preview-7bb388270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants