Skip to content

Exclude test folder from @metamask/gator-permissions-controller build artifact #7925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeffsmale90 wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

Exclude test folder from @metamask/gator-permissions-controller build artifact #7925

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/gator-permissions-controller/tsconfig.build.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@
{ "path": "../messenger/tsconfig.build.json" },
{ "path": "../transaction-controller/tsconfig.build.json" }
],
"include": ["../../types", "./src"]
"include": ["../../types", "./src"],
"exclude": ["./src/test"]
}
3 changes: 2 additions & 1 deletion packages/gator-permissions-controller/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,6 @@
{ "path": "../messenger" },
{ "path": "../transaction-controller" }
],
"include": ["../../types", "./src"]
"include": ["../../types", "./src"],
"exclude": ["./src/test"]
Copy link

@cursor cursor bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test files lose type-checking in development tsconfig

Medium Severity

The "exclude": ["./src/test"] was added to tsconfig.json, but this file is used for editor type-checking and linting — not for builds. Every other package in this repo (assets-controller, assets-controllers, eth-json-rpc-middleware) only excludes test paths from tsconfig.build.json, never from tsconfig.json. This causes standalone test files like errors.test.ts inside ./src/test/ to silently lose type-checking in the IDE and during lint, which contradicts the PR's stated goal of only excluding the test folder from the build artifact.

Fix in Cursor Fix in Web

}
Loading