feat(ramps): adds widget url to ramps controller state#7920
Merged
georgeweiler merged 12 commits intomainfrom Feb 13, 2026
Merged
feat(ramps): adds widget url to ramps controller state#7920georgeweiler merged 12 commits intomainfrom
georgeweiler merged 12 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
georgeweiler
changed the title
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
amitabh94
approved these changes
Feb 13, 2026
Contributor
amitabh94
left a comment
amitabh94
left a comment
There was a problem hiding this comment.
LGTM !
Approving but let's try to complete the reviewer checklist in the PR description going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Summary
widgetUrlresource toRampsControllerStatewithdata,isLoading, anderrorfields, following the existingResourceStatepatternsetSelectedQuoteor auto-selection during polling), the widget URL is automatically fetched from the service and stored in stategetWidgetUrl()method is preserved for backwards compatibility but marked as@deprecatedin favor of readingstate.widgetUrlReferences
Checklist
Note
Medium Risk
Introduces new async side effects on quote selection/polling and changes controller state shape, which could affect consumers and increase request volume if not handled carefully.
Overview
Adds a new
state.widgetUrlResourceState<BuyWidget | null>toRampsControllerand wires it to automatically fetch buy widget info viaRampsService:getBuyWidgetUrlwheneverquotes.selectedchanges (manual selection or polling auto-selection), using a stale-while-revalidate approach to avoid loading-state flicker.Resets
widgetUrlalongside other dependent-resource resets (e.g., provider/token changes or clearing the quote), marksgetWidgetUrl()as deprecated in favor of readingstate.widgetUrl, and updates/extends tests and changelog to cover the new state shape and error handling.Written by Cursor Bugbot for commit 38a9cf6. This will update automatically on new commits. Configure here.