chore(profile-metrics-controller): replace Sinon with Jest in ProfileMetricsService tests#7916
Draft
cryptodev-2s wants to merge 1 commit intomainfrom
Draft
chore(profile-metrics-controller): replace Sinon with Jest in ProfileMetricsService tests#7916cryptodev-2s wants to merge 1 commit intomainfrom
Sinon with Jest in ProfileMetricsService tests#7916cryptodev-2s wants to merge 1 commit intomainfrom
Conversation
…MetricsService tests
Sinon with Jest in ProfileMetricsService testsSinon with Jest in ProfileMetricsService tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…MetricsService tests
Explanation
References
Checklist
Note
Low Risk
Test-only refactor that swaps fake-timer implementations and removes a dev dependency; risk is limited to potential flakiness/regressions in
ProfileMetricsServicetiming-related tests.Overview
Refactors
ProfileMetricsService.test.tsto stop using Sinon fake timers and instead use Jest fake timers, updating retry/degraded/circuit-break tests to advance timers viajest.advanceTimersByTimeand to mockperformance.now/Date.nowwhere needed.Removes the
sinondev dependency from@metamask/profile-metrics-controller(andyarn.lock) and updates the test import to useHttpErrorfrom@metamask/controller-utils.Written by Cursor Bugbot for commit 3d4a72a. This will update automatically on new commits. Configure here.