Merged
Conversation
micaelae
previously approved these changes
Feb 13, 2026
864c9bf to
0a49a98
Compare
ghgoodreau
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR fixes issues with non-EVM chains metrics fields:
usd_amount_source,usd_quoted_gas, andusd_quoted_returnbeing empty.BTC > Ethereum ETH
Solana USDC > Ethereum USDC
Solana SOL > Solana USDC
References
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-3592
Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4121
Checklist
Note
Medium Risk
Changes exchange-rate derivation logic for non-EVM chains and alters emitted metrics defaults; risk is mainly incorrect USD calculations if
currencyRatesis missing or inconsistent.Overview
Fixes metrics gaps for non-EVM swaps/bridges by deriving
usdExchangeRatefrom multichain asset rates using an inferred user-currency→USD conversion factor, enablingusd_amount_source,usd_quoted_gas, andusd_quoted_returnto be populated.Also changes EVM transaction metrics defaults so
usd_amount_sourceis 0 instead of 100, and updates/expands unit tests and snapshots accordingly; both packages’ changelogs are updated.Written by Cursor Bugbot for commit 7ee3057. This will update automatically on new commits. Configure here.