-
-
Notifications
You must be signed in to change notification settings - Fork 275
perf!: Add accountIdByAddress to AccountsController state
#7893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hmalik88
wants to merge
22
commits into
main
Choose a base branch
from
hm/mul-1449
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+326
−4
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8c3c673
test: update tests with new controller state
hmalik88 9b006a5
chore: add new state to strict state typing
hmalik88 5238f32
feat: add getAccountIdByAddress mapping and update getAccountByAddres…
hmalik88 665ca3b
chore: update changelog
hmalik88 9097c69
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 56edc9c
fix: address bugbot comments
hmalik88 67be1db
fix: lint fix
hmalik88 a08cf5b
fix: update test
hmalik88 263f1d7
fix: fix test
hmalik88 b5e251d
refactor: change accountIdByAddress to not be persisted
hmalik88 b76f861
fix: address bugbot comment
hmalik88 4fbd0b0
fix: fix profilemetricscontroller test
hmalik88 0dd1904
fix: lint fix
hmalik88 45f7c30
fix: rehydrate accountIdByAddress in constructor
hmalik88 7991aeb
fix: update token selectors test
hmalik88 9764f02
fix: make test consistent with actual behavior
hmalik88 00a1a4a
fix: fix test
hmalik88 c573242
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 6f6b805
fix: fix test
hmalik88 b4e1d52
fix: fix test
hmalik88 dd8ae7d
fix: update test
hmalik88 27e39dd
Merge remote-tracking branch 'origin/main' into hm/mul-1449
hmalik88 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this breaking?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It classifies as breaking since we have to write a migration in the clients no?
getAccountByAddresscalls would break.