Skip to content

Add K9 Finance (K9) token metadata #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
simplefarmer69 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add K9 Finance (K9) token metadata #1818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b844623
Add K9 Finance (K9) token metadata
simplefarmer69 May 18, 2026
10800e7
Fix: use on-chain token name "K9" instead of "K9 Finance"
simplefarmer69 May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added icons/eip155:1/erc20:0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions metadata/eip155:1/erc20:0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"logo": "./icons/eip155:1/erc20:0xbc920c7Fa25D3Cd5606394aa4C6751d71DCb7930.png",
"name": "K9",
Copy link
Copy Markdown

@cursor cursor Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Token name field contradicts PR description

Low Severity

The name field is set to "K9", which is identical to the symbol field. The PR description explicitly states the token Name is "K9 Finance" and the Symbol is "K9", suggesting name was intended to be "K9 Finance". In this repo, name typically represents the full human-readable token name (e.g., "Uniswap" not "UNI", "Basic Attention Token" not "BAT"), so having name equal symbol loses descriptive information.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 10800e7. Configure here.

Copy link
Copy Markdown
Author

@simplefarmer69 simplefarmer69 May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name field is correctly set to "K9" — this is the token's actual on-chain name as returned by token.name(). The initial PR description was inaccurate in calling it "K9 Finance"; the on-chain name is simply "K9" (same as the symbol). Using the on-chain name is the most accurate representation and avoids confusion with the unrelated K9 Finance DAO project.

"symbol": "K9",
"decimals": 18,
"erc20": true
}