feat: add 7702 methods to ledger#564
Open
montelaidev wants to merge 5 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d244a63. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds the 7702 methods to the ledger keyring. The method itself is not usable until the dmk support has been added.
Examples
Note
Medium Risk
Introduces new hardware-backed authorization signing and signature recovery; iframe/mobile paths reject the operation until device support lands, but mistakes in parity or recovery could affect account safety.
Overview
Adds EIP-7702 delegation authorization signing to the Ledger keyring:
LedgerKeyring.signEip7702Authorizationunlocks the account, calls a new bridge methoddeviceSignDelegationAuthorization(chainId, contract address without0x, nonce), normalizes Ledgervto y-parity, and verifies the result withrecoverEIP7702Authorization.The
LedgerBridgecontract gains delegation sign types anddeviceSignDelegationAuthorization. Iframe and mobile bridges implement the method by throwing (not supported on those transports yet; PR notes DMK work is still pending).Personal sign and EIP-712 paths now use a shared
#parseLedgerRecoveryParamso Ledgervvalues like hex'1b'parse correctly before legacy normalization.The v2
LedgerKeyringadvertisesSignEip7702Authorizationin account methods (viaEthKeyringMethod). Changelog and Jest coverage thresholds are updated; tests cover the new flow and recovery-param edge cases.Reviewed by Cursor Bugbot for commit f1b063e. Bugbot is set up for automated code reviews on this repo. Configure here.