Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
mathieuartu
reviewed
Dec 8, 2025
packages/keyring-internal-snap-client/src/v2/KeyringInternalSnapClientV2.ts
Outdated
Show resolved
Hide resolved
packages/keyring-internal-snap-client/src/v2/KeyringInternalSnapClientV2.ts
Outdated
Show resolved
Hide resolved
packages/keyring-internal-snap-client/src/v2/KeyringInternalSnapClientV2.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Mathieu Artu <mathieu.artu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar implementation than
KeyringClientbut using the new unified keyring API (keyring v2) methods.Note
Adds first-class support for the unified keyring v2 RPC surface across API, clients, and SDK.
keyring-apiv2 RPC:KeyringRpcV2Method, request/response structs (getAccount(s),createAccounts,deleteAccount,exportAccount,submitRequest), andisKeyringRpcV2Methodkeyring-snap-clientKeyringClientV2implementing v2 methods with strict response validation and export fromv2/indexkeyring-internal-snap-clientKeyringInternalSnapClientV2usingSnapControllerMessengerSender, supportswithSnapId, and exportskeyring-snap-sdkhandleKeyringRequestV2to validate/dispatch v2 JSON-RPC requests, throwingMethodNotSupportedErrorwhen appropriateisKeyringRpcMethodis now a type guard and test message correctedWritten by Cursor Bugbot for commit f142721. This will update automatically on new commits. Configure here.