fix(keyring-eth-ledger-bridge): trim 0x prefix for signTransaction (due to latest @ethereumjs upgrade)#253
Merged
dawnseeker8 merged 1 commit intomainfrom Mar 21, 2025
Conversation
…nTransaction which cause ledger library break.
Contributor
Author
|
@metamaskbot publish-preview |
|
Preview builds have been published. See these instructions (from the Expand for full list of packages and versions. |
0x prefix for sign transaction (due to latest @ethereumjs upgrade)
0x prefix for sign transaction (due to latest @ethereumjs upgrade)0x prefix for signTransaction (due to latest @ethereumjs upgrade)
ccharly
approved these changes
Mar 21, 2025
Contributor
ccharly
left a comment
There was a problem hiding this comment.
Code LGTM, I haven't tested it myself though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix the ledger sign transaction issue due to this ethereumjs upgrade PR #209
and basically the ethereumjs upgrade code change make the transaction rawTxHex contain
0xprefix which is not valid for to @ledgerhq/hw-eth-app clearSignTransaction function. that functions expect a rawTxHex without0xprefix.