feat: add GlobalKillCondition for deal/cert/scrip#96
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 36b5725bbd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| function lowerKill() external onlyOwner { | ||
| if (killVotes[msg.sender]) { | ||
| killVotes[msg.sender] = false; | ||
| killCount--; |
There was a problem hiding this comment.
Because lowerKill() only clears killVotes[msg.sender], a raised vote becomes unremovable if that owner later loses OWNER_ROLE in BorgAuth (role rotation, compromise response, or accidental demotion). In that state, killCount stays nonzero forever, so checkCondition and checkTransferRestriction permanently block deal finalization and transfers. This introduces a platform-wide freeze path that current owners cannot recover from.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
understood. Other owners could still add him back if it was a mistake
1 participant
No description provided.