fix: limit guild membership display to 3 on player cards#1795
Closed
Ai-chan-0411 wants to merge 2 commits intoMetaFam:developfrom
Closed
fix: limit guild membership display to 3 on player cards#1795Ai-chan-0411 wants to merge 2 commits intoMetaFam:developfrom
Ai-chan-0411 wants to merge 2 commits intoMetaFam:developfrom
Conversation
Issue MetaFam#1774: When users connect their wallet and try to edit their profile, they receive confusing 'No wallet connected' error even though wallet is connected. Root cause: useSaveToComposeDB was only checking if user object was loaded, not distinguishing between 'wallet not connected' vs 'user data not loaded yet'. Fixes: - Add isConnected check from wagmi hook for clear wallet connection state - Improve error messages to distinguish between different failure scenarios - Add validation for user.address to catch incomplete profile data - Include isConnected in useCallback dependency array This ensures users get appropriate feedback when wallet is actually disconnected vs when user data is still loading after wallet connection. Closes MetaFam#1774
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
@aoi-dev-0411 is attempting to deploy a commit to the MetaFamily Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Closing due to no review activity. Thank you for the opportunity! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1629
Changes
This prevents guild memberships from breaking into multiple rows and keeps player cards visually consistent.