Add HIRAS2 observation type for use in JOPA #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into feature/add_hiras2
mo-RowanMcL
changed the title
mo-RowanMcL
requested review from
DJDavies2,
adammaycock,
ctgh,
matthewrmshin,
mikecooke77 and
yaswant
as code owners
DJDavies2
approved these changes
Jan 7, 2026
ctgh
reviewed
Jan 8, 2026
Collaborator
ctgh
left a comment
ctgh
left a comment
There was a problem hiding this comment.
Thanks for adding this. If it's not too much trouble to add Cx and Varobs writer tests that would be good, just to make sure everything is covered.
Contributor
Author
Cx and Varobs writer tests now complete. |
ctgh
approved these changes
Jan 12, 2026
Collaborator
ctgh
left a comment
ctgh
left a comment
There was a problem hiding this comment.
Thanks for adding the new tests. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most changes are 1-1 with CrIS or HIRAS processing already present.
I have not created a CxWriter test, is this a necessary step here?
sith run showing correct extraction: https://cylchub/services/cylc-review/taskjobs/rowan.mclaughlin/?suite=sith%2Fhiras2_auxdocs_merge