Open
Conversation
james-bruten-mo
approved these changes
Mar 18, 2026
Collaborator
james-bruten-mo
left a comment
There was a problem hiding this comment.
Thanks, this looks a sensible. I've checked it works in rose stem and suites, and with the jules-internal repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: @james-bruten-mo
Extract the repository name from the merge source string, rather than passing down the name of the destination directory. This allows source to be extracted from a mirror even when the destination directory name does not match the name of the repository.
Null change except when using
localmirrors:.closes #212
Code Quality Checklist
Testing
Tested with rose-stem:
extract_source/job.errof UM rose-stem:extract_source/job.errof MOCI rose-stem:Further testing with a branch of a UKESM suite:
https://code.metoffice.gov.uk/trac/roses-u/browser/d/x/0/3/3/double_moci_extract
This suite uses a single stage extract direct onto HPC and therefore exclusively uses localmirrors. The branch has been set up to extract and run with 2 moci.git extracts into
Extract from log
extract/job.err:Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review