Skip to content

Improve clarity of Background and remove unneeded f strings #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericpapaluca wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve clarity of Background and remove unneeded f strings #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ea72f0
Update test_etl.py
ericpapaluca Oct 3, 2024
0abe118
Update README.md
ericpapaluca Oct 3, 2024
a057ce1
Merge pull request #1 from ericpapaluca/patch-1
ericpapaluca Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ The objective of this challenge is to gain insights on problem-solving approache

## Background

A client receives sales data in a text file (CSV format). Each row in this file contains item_id, order_id, product_name, quantity, unit_price.
A client receives sales data in a text file (CSV format). Each row in this file contains a record with columns of the schema item_id, order_id, product_name, quantity, unit_price.

The client wants to keep this information in a more accessible storage solution (e.g. a database). Therefore they have created a small python ETL tool to store this data in SQLite. On the back of this, they have created a revenue report with the top 2 products that looks like this:

Expand All @@ -30,4 +30,4 @@ You are provided with scaffolding code necessary to solve this task:

There are many ways of solving the task so don't be afraid of being creative. Feel free to use additional libraries and code as needed.

**Happy coding!**
**Happy coding!**
2 changes: 1 addition & 1 deletion test/test_etl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ def tearDownClass(cls):


def _create_test_database(self):
self.engine = create_engine(f'{test_etl_script.test_db_path}', echo=True)
self.engine = create_engine(test_etl_script.test_db_path, echo=True)

def _delete_test_database(self):
# Delete the test SQLite database
Expand Down