Fix issue with gpkg reconstruction from merged diffs#605
Open
Fix issue with gpkg reconstruction from merged diffs#605
Conversation
Pull Request Test Coverage Report for Build 23799172936Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue:
In certain cases full gpkg file could not be reconstructed from diff checkpoints as those were incorrect.
Typically it happened when diff checkpoint started at version of basefile (e.g. v1) and during its construction from lower ranks starting diff was ignored leading to invalid checkpoint file.
Imagine situation like this when we wanted to create some higher rank checkpoint:
where first checkpoint in the list was originally ignored.
Fix:
This PR lessens the condition when checkpoint should be ignored only to situation if it spanned over basefile version.