-
Notifications
You must be signed in to change notification settings - Fork 60
Don't reveal private project exists to anonymous user #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelGeo
requested changes
Nov 28, 2025
varmar05
requested changes
Nov 28, 2025
Pull Request Test Coverage Report for Build 19921201757Details
💛 - Coveralls |
varmar05
reviewed
Dec 2, 2025
varmar05
approved these changes
Dec 3, 2025
MarcelGeo
approved these changes
Dec 3, 2025
Collaborator
MarcelGeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fix a test and it's fine :)
Do not update global config variable for gevent mode. Make sure we do not use gevent env for tests apart of dedicated tests. In those tests mock configuration rather than modifing global variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/MerginMaps/server-private/issues/3087#issuecomment-3586086194
return
404to anonymous user requesting private project infoa new flag ensures it is applied only in specific endpoints -> does not affect other responses but v2 get project info
add validation for version in API spec