Create checkpoint recursively #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for file diffs we only create higher ranks if it makes sense (contains changes) - if delta cannot be created / fetched return on error
Pull Request Test Coverage Report for Build 19674760225Details
💛 - Coveralls |
MarcelGeo
approved these changes
Nov 25, 2025
Collaborator
MarcelGeo
left a comment
MarcelGeo
left a comment
There was a problem hiding this comment.
Just wondering, If we do not want flask command where projectId will be as argument. This command will create checkpoints tree for some project. We do not need to manage it trough api call.
Do not update global config variable for gevent mode. Make sure we do not use gevent env for tests apart of dedicated tests. In those tests mock configuration rather than modifing global variable.
MarcelGeo
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite fallback logic for create checkpoints functions (both merged diffs and project deltas) to create intermediate (lower ranks) checkpoints if missing recursively instead of using individual diffs directly.
Advantage of this approach is that in case of too heavy request which would not complete from individual diffs now it would at least cache some partial results.