New Monthly Contributors Error Dialog #640
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VitorVieiraZ
force-pushed
the
enhancement/newProjectLimitHitDialog
branch
from
1f24f80 to
b187b78
Compare
VitorVieiraZ
changed the title
VitorVieiraZ
changed the title
ValentinBuira
suggested changes
Nov 15, 2024
Contributor
ValentinBuira
left a comment
ValentinBuira
left a comment
There was a problem hiding this comment.
Just few things I am not quite sure to understand otherwise look good to me
I added few general tips feel free to ignore them and mark them as solved
ValentinBuira
approved these changes
Nov 19, 2024
tomasMizera
requested changes
Nov 20, 2024
tomasMizera
approved these changes
Nov 22, 2024
Contributor
tomasMizera
left a comment
tomasMizera
left a comment
There was a problem hiding this comment.
Looking good on the plugin side, only some tiny comment. Feel free to squash and merge after addressing it!
Comment on lines
+27
to
+30
| quota = self.server_response.get("contributors_quota", "#NA") | ||
| quota_text = ( | ||
| f"You've reached the maximum number of active monthly contributors ({quota}) for your current subscription." | ||
| ) |
Contributor
There was a problem hiding this comment.
Just some nit picking - this might seem more friendly for users in case we have issues reading the quota
Suggested change
| quota = self.server_response.get("contributors_quota", "#NA") | |
| quota_text = ( | |
| f"You've reached the maximum number of active monthly contributors ({quota}) for your current subscription." | |
| ) | |
| quota = self.server_response.get("contributors_quota", None) | |
| quota_text = ( | |
| f"You've reached the maximum number of active monthly contributors {'(' + quota + ')' if quota else ''} for your current subscription." | |
| ) |
Contributor
|
Let's just bear in mind that we need a new Python-api-client version when releasing this one! |
tomasMizera
added
the
requires dependency release
Contributor
|
This work is not needed now with the recent changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displays
Monthly Contributos Error Dialogwhen creating a project or syncing in case of failure.Resolves #643, Python-api-client update: MerginMaps/python-api-client#221