Skip to content

Fixed the top and bottom over-padding for feature list page drawer #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gabriel-bolbotina wants to merge 1 commit into
base: dev/qt-6.10.2
Choose a base branch
from
+16 −2
Draft

Fixed the top and bottom over-padding for feature list page drawer #4510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/qml/components/MMDrawer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ Drawer {
edge: Qt.BottomEdge
dragMargin: 0

// Qt 6.9+ Popup/Drawer automatically applies safe area margins as padding.
topPadding: 0
bottomPadding: 0
leftPadding: 0
rightPadding: 0

// rounded background
background: Rectangle {
color: __style.polarColor
Expand Down
12 changes: 10 additions & 2 deletions app/qml/form/components/MMFeaturesListPageDrawer.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ Drawer {
height: ApplicationWindow.window.height

edge: Qt.BottomEdge
padding: 0

// Qt 6.9+ Popup/Drawer automatically applies safe area margins as padding.
topPadding: 0
bottomPadding: 0
leftPadding: 0
rightPadding: 0

contentItem: MMComponents.MMPage {
id: page
Expand Down Expand Up @@ -123,7 +128,10 @@ Drawer {
text: qsTr( "Add feature" )
visible: __activeProject.projectRole !== "reader"

onClicked: root.buttonClicked()
onClicked: {
root.close()
root.buttonClicked()
}
}
}
}
Expand Down
Loading