Added notification when a project has a newer version available on the server#4386
Open
gabriel-bolbotina wants to merge 4 commits intomasterfrom
Open
Added notification when a project has a newer version available on the server#4386gabriel-bolbotina wants to merge 4 commits intomasterfrom
gabriel-bolbotina wants to merge 4 commits intomasterfrom
Conversation
Pull Request Test Coverage Report for Build 23788727144Details
💛 - Coveralls |
📦 Build Artifacts Ready
|
Withalion
reviewed
Mar 26, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
It will need some more work as mentioned in main.qml. Also I don't really like the visuals of the notification. Why is the text a link? I propose to use the same design as we want to do in filtering notifications (Figma). It would be great to replace the close icon with "sync" button, let's discuss it.
📦 Build Artifacts Ready
|
Withalion
reviewed
Mar 29, 2026
Contributor
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
Besides the comments below, the project list shows information that user has "pending changes to synchronise" even though there are no changes done to the project locally, if there is newer version of project available on server. I don't think we want to show that info if there are no local changes.
📦 Build Artifacts Ready
|
Implemented code findings
gabriel-bolbotina
force-pushed
the
project-update-req-notification
branch
from
342f9c5 to
51d1f82
Compare
📦 Build Artifacts Ready
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a function in mergin api that checks if the project needs a sync and fires a notification in case it is needed.
Tested to work for the currently open project and when switching from one project to another
Use case below:
https://github.com/user-attachments/assets/e0c01bec-5a55-4e22-82a4-2a50c673825b