Skip to content

Conversation

@gabriel-bolbotina
Copy link
Contributor

Ready for review.
Added Auth sync class that handles the importation of authentication database configuration file.

Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exercise with the new AuthSync class is now feeling a bit too much - it's basically just calling the import method 🙃 I suggest we get rid of it altogether. In addition to that, the PR:

  • is missing autotests
  • missed project reload in case the auth file is changed
  • missed to reset auth entries before loading the auth db

Good job with the ossl linking fix.

ProjectDiff diff = transaction.diff;
int newVersion = syncSuccessful ? transaction.version : -1;

// TODO check if the xml configuration has been changed
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO?

Copy link
Contributor Author

@gabriel-bolbotina gabriel-bolbotina Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to only modify the xml configuration file from QGIS. Upon syncing, it was already detected by that function, which emitted a force reload of the project. So I don't think we should specifically check for the cfg modification at all.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check this video.

@tomasMizera tomasMizera added the FROZEN 🥶 do not merge before upcoming release label Dec 15, 2025
@gabriel-bolbotina gabriel-bolbotina force-pushed the feature/qgis-auth-db-sync branch from 8c4755a to 2281cca Compare December 15, 2025 13:32
@gabriel-bolbotina gabriel-bolbotina self-assigned this Dec 16, 2025
@Withalion Withalion linked an issue Dec 17, 2025 that may be closed by this pull request
@Withalion Withalion removed the FROZEN 🥶 do not merge before upcoming release label Dec 18, 2025
@Withalion
Copy link
Contributor

Some ideas for testing:

  • test opening project without qgis auth db exported and private layer (opening the project should succeed, but layer should be available)
  • test opening project with qgis auth db ( opening the project should succeed and layer should be available)
  • test synchronizing project should trigger reload of auth db

@github-actions
Copy link

Pull Request Test Coverage Report for Build 20343044770

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 644 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.006%) to 59.747%

Files with Coverage Reduction New Missed Lines %
mm/app/position/providers/simulatedpositionprovider.cpp 1 90.91%
mm/app/autosynccontroller.cpp 2 85.71%
mm/app/projectsmodel.cpp 5 68.1%
mm/app/multieditmanager.cpp 6 50.0%
mm/app/maptools/splittingmaptool.cpp 8 79.59%
mm/app/position/positionkit.cpp 25 77.78%
mm/app/variablesmanager.cpp 36 26.32%
mm/app/synchronizationmanager.cpp 38 60.0%
mm/app/activeproject.cpp 69 71.01%
mm/app/main.cpp 84 36.46%
Totals Coverage Status
Change from base Build 20231699821: -0.006%
Covered Lines: 8591
Relevant Lines: 14379

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to import QGIS auth DB from file

4 participants