Skip to content

Conversation

@Withalion
Copy link
Contributor

@Withalion Withalion commented Nov 28, 2025

fixes #4237

By default the app uses EGM96 geoid model to recalculate the elevation. Sometimes there is a need for more precise model, which is local to some area. With the work done in MerginMaps/qgis-plugin#841 admins can setup custom geoid model. This PR changes the mobile app behaviour to use the custom model if it's setup and shows user the current model in use.

For local geoid models, if current position is outside the model area we should show N/A values for Altitude and Geoid Separation. The code for this behaviour might be missing in some providers, I'm waiting for dev/geoid-support be merged it will be implemented in dev/geoid-support

@github-actions
Copy link

github-actions bot commented Nov 28, 2025

Pull Request Test Coverage Report for Build 19823024385

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 341 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.05%) to 59.566%

Files with Coverage Reduction New Missed Lines %
mm/app/position/providers/bluetoothpositionprovider.cpp 5 77.36%
mm/app/position/providers/simulatedpositionprovider.cpp 7 86.73%
mm/app/position/providers/internalpositionprovider.cpp 34 20.66%
mm/app/position/positionkit.cpp 57 73.11%
mm/app/inpututils.cpp 238 52.94%
Totals Coverage Status
Change from base Build 19822206753: -0.05%
Covered Lines: 8596
Relevant Lines: 14431

💛 - Coveralls

@Withalion Withalion linked an issue Nov 28, 2025 that may be closed by this pull request
@Withalion Withalion requested a review from tomasMizera December 1, 2025 08:22
@Withalion Withalion marked this pull request as ready for review December 1, 2025 08:22
@Withalion Withalion force-pushed the feature/custom-geoid-support branch from 7fad8a4 to 1d770ff Compare December 1, 2025 12:41
Copy link
Collaborator

@tomasMizera tomasMizera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 🔝

@Withalion Withalion merged commit d02bfd3 into dev/geoid-support Dec 2, 2025
11 of 12 checks passed
@Withalion Withalion deleted the feature/custom-geoid-support branch December 2, 2025 08:16
@wonder-sk
Copy link
Contributor

@Withalion shouldn't we set elevation and elevation_diff to NaN when positionOutsideGeoidModelArea = true ? It seems this is currently being done only in the simulated provider.

Also, what happens if a vertical grid is missing in transformPoint()? Ideally we should show an error message, as it is important that user knows there is an issue, and get it fixed ASAP, rather than quietly recording incorrect measurements...

@Withalion
Copy link
Contributor Author

  1. it's not visible here as the work for other providers was done in GNSS PR
  2. I do believe we show it to the users let me check and if not then we log it at least

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support custom geoid models

4 participants